Skip to content

ci-operator: add kubecsr #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Mar 11, 2019
Merged

ci-operator: add kubecsr #3021

openshift-merge-robot merged 2 commits into from
Mar 11, 2019

Conversation

@hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Mar 6, 2019

This PR adds openshift/kubecsr which will create 2 images that are needed for 4.0.

  • kube-client-agent
  • kube-etcd-signer-server

depends on https://github.com/openshift/kubecsr/pulls

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 6, 2019
@hexfusion hexfusion force-pushed the add_kubecsr branch 2 times, most recently from 5b871a1 to 3469b35 Compare March 6, 2019 18:55
@hexfusion
ci-operator: add kubecsr
e43e260 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 7, 2019

/test pj-rehearse

1 similar comment
@petr-muller
Copy link
Member

petr-muller commented Mar 7, 2019

/test pj-rehearse

@petr-muller
Copy link
Member

petr-muller commented Mar 7, 2019

Rehearse is likely broken because of the recent ci-operator config CM sharding. Should be fixed once openshift/ci-operator-prowgen#104 lands

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 7, 2019

@petr-muller thanks could you also add direction for steps required to complete build process do I need to setup anything in CI etc?

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 8, 2019

/test pj-rehearse

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 8, 2019

/cc @smarterclayton @ericavonb @abhinavdahiya

@petr-muller
Copy link
Member

petr-muller commented Mar 8, 2019

@petr-muller thanks could you also add direction for steps required to complete build process do I need to setup anything in CI etc?

Yeah you'll need to add few more lines, please see the https://docs.google.com/document/d/1SQ_qlkcplqhe8h6ONXdgBr7YUVbs4oRSj4ISl3gpLW4/edit (especially the checklist at the end).

abhinavdahiya
abhinavdahiya approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@abhinavdahiya abhinavdahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@hexfusion
cluster/ci: enable prow
62b3eec 
Signed-off-by: Sam Batschelet <[email protected]>
stevekuznetsov
stevekuznetsov reviewed Mar 8, 2019
View reviewed changes
ci-operator/config/openshift/kubecsr/openshift-kubecsr-openshift-4.0.yaml
name: '4.0'
namespace: ocp
tag: base
canonical_go_repository: github.com/coreos/kubecsr
Copy link
Contributor

@stevekuznetsov stevekuznetsov Mar 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this how the code is imported in Go? Or is the repo actually under coreos org?

Copy link
Contributor Author

@hexfusion hexfusion Mar 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the repo is openshift org, the code is imported as above.

Copy link
Contributor Author

@hexfusion hexfusion Mar 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar situation to etcd

petr-muller
petr-muller approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, hexfusion, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit e0b6e91 into openshift:master Mar 11, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 11, 2019

@hexfusion: Updated the following 5 configmaps:

  • ci-operator-4.0-configs configmap in namespace ci using the following files:
    • key openshift-kubecsr-openshift-4.0.yaml using file ci-operator/config/openshift/kubecsr/openshift-kubecsr-openshift-4.0.yaml
  • ci-operator-4.0-configs configmap in namespace ci-stg using the following files:
    • key openshift-kubecsr-openshift-4.0.yaml using file ci-operator/config/openshift/kubecsr/openshift-kubecsr-openshift-4.0.yaml
  • job-config-4.0 configmap in namespace ci using the following files:
    • key openshift-kubecsr-openshift-4.0-presubmits.yaml using file ci-operator/jobs/openshift/kubecsr/openshift-kubecsr-openshift-4.0-presubmits.yaml
    • key openshift-kubecsr-openshift-4.0-postsubmits.yaml using file ci-operator/jobs/openshift/kubecsr/openshift-kubecsr-openshift-4.0-postsubmits.yaml
  • config configmap in namespace ci using the following files:
    • key config.yaml using file cluster/ci/config/prow/config.yaml
  • plugins configmap in namespace ci using the following files:
    • key plugins.yaml using file cluster/ci/config/prow/plugins.yaml
Details

In response to this:

This PR adds openshift/kubecsr which will create 2 images that are needed for 4.0.

  • kube-client-agent
  • kube-etcd-signer-server

depends on https://github.com/openshift/kubecsr/pulls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion deleted the add_kubecsr branch March 11, 2019 12:31
wking added a commit to wking/origin that referenced this pull request Mar 15, 2019
@wking
pkg/oc/cli/admin/release/new: Always include kube-etcd-signer-server
060dff5 
Taking advantage of openshift/release@e43e260f59 (ci-operator: add
kubecsr, 2019-03-06, openshift/release#3021) to get this installer
dependency into the release image.
@wking wking mentioned this pull request Mar 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericavonb ericavonb Awaiting requested review from ericavonb

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

3 more reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@petr-muller petr-muller petr-muller approved these changes

@abhinavdahiya abhinavdahiya abhinavdahiya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@petr-muller petr-muller

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hexfusion @petr-muller @openshift-ci-robot @abhinavdahiya @stevekuznetsov @openshift-merge-robot